xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: don't block on buffer read errors

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: don't block on buffer read errors
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 14 Jul 2010 14:28:36 -0400
Cc: xfs@xxxxxxxxxxx, axboe@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1279007450-10457-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1279007450-10457-1-git-send-email-david@xxxxxxxxxxxxx> <1279007450-10457-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
Looks good, except that I'd rework the snipplet below

>       status = xfs_buf_iorequest(bp);
> -     if (!status && !(flags & XBF_ASYNC))
> +     if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
>               status = xfs_buf_iowait(bp);
>       return status;

as:

        if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
                return status;
        return xfs_buf_iowait(bp);

to make it a bit more clear.

<Prev in Thread] Current Thread [Next in Thread>