xfs
[Top] [All Lists]

Re: [PATCH xfstests] _qmount: mount w/o selinux xattrs

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH xfstests] _qmount: mount w/o selinux xattrs
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Tue, 13 Jul 2010 11:40:15 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20100712221346.GI25335@dastard>
References: <4C2CF34F.7070008@xxxxxxxxxx> <20100702071006.GB30776@xxxxxxxxxxxxx> <4C2E2687.3080700@xxxxxxxxxx> <20100709161232.GA26302@xxxxxxxxxxxxx> <4C3B6D0A.2010708@xxxxxxxxxx> <20100712221346.GI25335@dastard>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc11 Lightning/1.0b2pre Thunderbird/3.0.3
On 07/12/2010 05:13 PM, Dave Chinner wrote:
> On Mon, Jul 12, 2010 at 02:29:14PM -0500, Eric Sandeen wrote:
>> On 07/09/2010 11:12 AM, Christoph Hellwig wrote
>>> On Fri, Jul 02, 2010 at 12:48:55PM -0500, Eric Sandeen wrote:
>>>>> What about just disabling selinux for all filesystems instead of just
>>>>> XFS for the general case.
>>>>
>>>> Well it seems like if we -can- test with it on, that's good.
>>>> Certain distros ship with it on by default, so exercising lots
>>>> of scenarios with it on seems beneficial...
>>>
>>> It seems, but I'd rather do it consistently for all filesystems.
>>>
>>
>> except we can't, because xfs actually has such low-level format checking
>> that selinux -will- break it badly.
>>
>> I guess we could flag which tests can't run w/ extra xattrs,
>> and only mount w/ the context for those?
> 
> Maybe use a group to define all the tests that can't run with
> selinux enabled and check it before running each test? i.e. use
> notrun to prevent such tests from running. The attr group isprobably
> a good start for the tests that will break w/ selinux enabled....

Something like that ... but there are more tests than just the attr
group, I'm afraid.

I'd have to re-run to see which break, guess I'll put that on the list.

-Eric

> Cheers.
> 
> Dave.

<Prev in Thread] Current Thread [Next in Thread>