xfs
[Top] [All Lists]

Re: [PATCH] xfs: writepage always has buffers

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfs: writepage always has buffers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 12 Jul 2010 12:05:23 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1278906189.7456.22.camel@doink>
References: <20100628143457.GC5473@xxxxxxxxxxxxx> <1278906189.7456.22.camel@doink>
User-agent: Mutt/1.5.20 (2009-08-17)
On Sun, Jul 11, 2010 at 10:43:09PM -0500, Alex Elder wrote:
> On Mon, 2010-06-28 at 10:34 -0400, Christoph Hellwig wrote:
> > These days we always have buffers thanks to ->page_mkwrite.  And we already
> > have an assert a few lines above tripping in case that was not true due to
> > a bug.
> 
> Should the ASSERT() be made stronger (i.e., BUG_ON())?
> Looks to me like we'll crash if it ever happens in a
> non-debug kernel, and a BUG() call would more directly
> tell us what the problem was...

The crash tells it quite directly as well, the ASSERT is there more as
a documentation of what we require.

<Prev in Thread] Current Thread [Next in Thread>