xfs
[Top] [All Lists]

Re: [PATCH xfstests] _qmount: mount w/o selinux xattrs

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH xfstests] _qmount: mount w/o selinux xattrs
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 02 Jul 2010 12:48:55 -0500
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20100702071006.GB30776@xxxxxxxxxxxxx>
References: <4C2CF34F.7070008@xxxxxxxxxx> <20100702071006.GB30776@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc11 Lightning/1.0b2pre Thunderbird/3.0.3
On 07/02/2010 02:10 AM, Christoph Hellwig wrote:
> On Thu, Jul 01, 2010 at 02:58:07PM -0500, Eric Sandeen wrote:
>> when selinux is on it can change quota usage due to extra
>> xattr blocks.
>>
>> Mounting with a context prevents this.  We already do so
>> for xfs in general because so many things look at detailed
>> on-disk format, and extra xattrs confuses those tests.
>>
>> For other filesystems, we've left selinux alone so far, 
>> as that seemed the best way to test.
>>
>> However, it throws quota accounting off, so add a fixup
>> in _qmount()
> 
> What about just disabling selinux for all filesystems instead of just
> XFS for the general case.

Well it seems like if we -can- test with it on, that's good.
Certain distros ship with it on by default, so exercising lots
of scenarios with it on seems beneficial...

-Eric

<Prev in Thread] Current Thread [Next in Thread>