[Top] [All Lists]

Re: [PATCH] xfstests: have getfacl(1) report numeric id's

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: have getfacl(1) report numeric id's
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 1 Aug 2010 10:15:49 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201007302154.o6ULsNdm008915@xxxxxxxxxxxxxxxxxxxxxx>
References: <201007302154.o6ULsNdm008915@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Fri, Jul 30, 2010 at 04:54:23PM -0500, Alex Elder wrote:
> This patch arranges for calls to getfacl(1) to be given the "-n"
> flag, which requests that user and group id's be listed numerically
> rather than using names.  The affected test output files are also
> updated to indicate the effect of the change.
> This eliminates some spurious output differences I was seeing, due
> to the presence of NIS in my test environment.
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

I wonder if this usage should be documented somewhere for future tests.

<Prev in Thread] Current Thread [Next in Thread>