xfs
[Top] [All Lists]

Re: [PATCH 03/15] xfs: move DMAPI definitions out of "xfs_mount.h"

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 03/15] xfs: move DMAPI definitions out of "xfs_mount.h"
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 29 Jun 2010 09:35:00 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201006282204.o5SM4qbU018132@xxxxxxxxxxxxxxxxxxxxxx>
References: <201006282204.o5SM4qbU018132@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Mon, Jun 28, 2010 at 05:04:52PM -0500, Alex Elder wrote:
> XFS defines a bunch of DMAPI cruft in xfs_mount.h.  There is no need
> for it to be there; move it instead into the xfs_dmapi.h file.  A
> side-effect of this is that "xfs_dmapi.h" now depends on and needs
> to be #included after "xfs_mount.h" and "xfs_inode.h" (the latter of
> which itself depends on a "xfs_bmap_btree.h").
> 
> On the other hand, "xfs_dmapi.h" is #included by a LOT more files
> than it needs to be, so eliminate those cases.
> 
> Finally, "xfs_inode.h" defines a type dm_attrs_t that is never
> referenced anywhere else, so kill it off.

Asserting copyright on removing single include lines seems rather
interesting..

<Prev in Thread] Current Thread [Next in Thread>