xfs
[Top] [All Lists]

[PATCH] xfs: writepage always has buffers

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: writepage always has buffers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 28 Jun 2010 10:34:57 -0400
User-agent: Mutt/1.5.20 (2009-08-17)
These days we always have buffers thanks to ->page_mkwrite.  And we already
have an assert a few lines above tripping in case that was not true due to
a bug.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfs-dev/fs/xfs/linux-2.6/xfs_aops.c
===================================================================
--- xfs-dev.orig/fs/xfs/linux-2.6/xfs_aops.c    2010-06-28 11:59:29.590253914 
+0200
+++ xfs-dev/fs/xfs/linux-2.6/xfs_aops.c 2010-06-28 11:59:48.341006462 +0200
@@ -1072,13 +1072,6 @@ xfs_vm_writepage(
        if ((current->flags & PF_FSTRANS) && (delalloc || unwritten))
                goto out_fail;
 
-       /*
-        * Delay hooking up buffer heads until we have
-        * made our go/no-go decision.
-        */
-       if (!page_has_buffers(page))
-               create_empty_buffers(page, 1 << inode->i_blkbits, 0);
-
        /* Is this page beyond the end of the file? */
        offset = i_size_read(inode);
        end_index = offset >> PAGE_CACHE_SHIFT;

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs: writepage always has buffers, Christoph Hellwig <=