xfs
[Top] [All Lists]

Re: [PATCH] xfs_db: check for valid inode data pointer before dereferenc

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_db: check for valid inode data pointer before dereferencing
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 26 Jun 2010 07:45:13 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1277418283-23381-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1277418283-23381-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Fri, Jun 25, 2010 at 08:24:43AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When processing an inode, the code checks various flags to determine
> whether to output messages or not. When checking the CLI provided
> inode numbers to be verbose about, we fail to check if the inode
> data structre returned is valid or not before dereferencing it.
> Hence running xfs_check with the "serious errors only" flag, xfs_db
> will crash. Fix up the "should we output" logic to be safe.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>