xfs
[Top] [All Lists]

Re: [PATCH] xfsqa: test 214 leaves files around that cause 236 to fail

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsqa: test 214 leaves files around that cause 236 to fail
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 21 Jun 2010 03:21:33 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1277077378-17927-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1277077378-17927-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Mon, Jun 21, 2010 at 09:42:58AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Test 214 and 236 use the same file names for test files in the TEST
> filesystem and don't check/create clean initial test state. Hence if
> you run 214 then 236, 236 will fail with:
> 
> +link: cannot create link `/mnt/test/ouch2' to `/mnt/test/ouch': File exists
> +ctime: 1277076527 -> 1277076527
> +Fatal error: ctime not updated after link
> 
> Ensure that both tests clean up after themselves properly and also
> ensure a clean state before they start.

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>