xfs
[Top] [All Lists]

Re: [PATCH] xfs: remove xfs_iput_new

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: remove xfs_iput_new
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 19 Jun 2010 16:35:23 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100615015300.GP6590@dastard>
References: <20100611161824.GA7556@xxxxxxxxxxxxx> <20100615015300.GP6590@dastard>
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Jun 15, 2010 at 11:53:00AM +1000, Dave Chinner wrote:
> On Fri, Jun 11, 2010 at 12:18:24PM -0400, Christoph Hellwig wrote:
> > We never get an i_mode of 0 or a locked VFS inode until we pass in the
> > XFS_IGET_CREATE flag to xfs_iget, which makes xfs_iput_new equivalent to
> > xfs_iput for the only caller.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

There's in fact no need to lock the inode at all here, so this can
be replaced with IRELE.   I'll send an updated version with my next
batch of patches.

<Prev in Thread] Current Thread [Next in Thread>