xfs
[Top] [All Lists]

Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warni

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2
From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Date: Wed, 16 Jun 2010 09:33:42 +0200
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, dgc@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <4C183B63.5090306@xxxxxxxxxxx>
References: <20100614081356.GA27499@xxxxxxxxxxxxxxx> <20100614083021.GA29354@xxxxxx> <4C15EF75.5080909@xxxxxxxxxxxxxxx> <20100614124804.GA8547@xxxxxx> <20100614133958.GH17092@xxxxxxxxxxxxxxx> <20100614163122.GB369@xxxxxxxxxxxxxxx> <4C183B63.5090306@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4

really?

$ make SUBDIRS=fs/xfs
   CC [M]  fs/xfs/linux-2.6/xfs_super.o
fs/xfs/linux-2.6/xfs_super.c:73:2: error: #error DEBUG
make[1]: *** [fs/xfs/linux-2.6/xfs_super.o] Error 1

$ grep -A3 XFS_DEBUG fs/xfs/linux-2.6/xfs_super.c
#ifdef CONFIG_XFS_DEBUG
#error DEBUG
#endif

(above just for testing)

Offtopic I guess, but it sure seems to set it for me.

You did a full build with XFS_DEBUG before without SUBDIRS, right?

Kbuild puts the options into special .cmd files and I think
those only get rebuild on a full build, not on a SUBDIRS
build. So it never picked up the changed option for me.

Anyways that's the current theory, haven't retested that.

-Andi

<Prev in Thread] Current Thread [Next in Thread>