xfs
[Top] [All Lists]

Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warni

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Tue, 15 Jun 2010 09:24:52 +0200
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, dgc@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20100615005442.GL6590@dastard>
References: <20100614081356.GA27499@xxxxxxxxxxxxxxx> <20100614083021.GA29354@xxxxxx> <4C15EF75.5080909@xxxxxxxxxxxxxxx> <20100614124804.GA8547@xxxxxx> <20100614133958.GH17092@xxxxxxxxxxxxxxx> <20100614163122.GB369@xxxxxxxxxxxxxxx> <20100615005442.GL6590@dastard>
User-agent: Mutt/1.5.17 (2007-11-01)
> I'm still not happy with it.

With the BUG_ON? 

> 
> We'll commit a modified version of one of your patches into the XFS
> tree as you seem unable to accept that changes might be necessary to
> get your code to pass review.

Sure modify however you like as long as you fix the warnings.

Also it was good to have review on the cases it warned about,
luckily there were no real bugs found.

[BTW I should add there were some more mostly from array
overflows. I have not investigated in detail, but I suspect
they were harmless]

My goal was also mostly to get my build reasonably warning free,
but if I can't get this patch in I can also just disable the warning
for fs/xfs. 

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

<Prev in Thread] Current Thread [Next in Thread>