[Top] [All Lists]

Re: [PATCH] xfs: new truncate sequence

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: new truncate sequence
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 15 Jun 2010 12:19:44 +1000
Cc: xfs@xxxxxxxxxxx, npiggin@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx
In-reply-to: <20100614091731.GA22088@xxxxxxxxxxxxx>
References: <20100614091731.GA22088@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jun 14, 2010 at 05:17:31AM -0400, Christoph Hellwig wrote:
> Convert XFS to the new truncate sequence.  We still can have errors after
> updating the file size in xfs_setattr, but these are real I/O errors and lead
> to a transaction abort and filesystem shutdown, so they are not an issue.
> Errors from ->write_begin and write_end can now be handled correctly because
> we can actually get rid of the delalloc extents while previous the buffer
> state was stipped in block_invalidatepage.
> There is still no error handling for ->direct_IO, because doing so will need
> some major restructuring given that we only have the iolock shared and do not
> hold i_mutex at all.  Fortunately leaving the normally allocated blocks behind
> there is not a major issue and this will get cleaned up by xfs_free_eofblock
> later.
> Note: the patch is against Al's vfs.git tree as that contains the nessecary
> preparations.  I'd prefer to get it applied there so that we can get some
> testing in linux-next.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

It looks sane, but I haven't done any testing on it.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>