[Top] [All Lists]

Re: [PATCH 3/3] xfs: simplify xfs_vm_writepage

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfs: simplify xfs_vm_writepage
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 15 Jun 2010 11:50:47 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100611161512.404472115@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100611161312.446670249@xxxxxxxxxxxxxxxxxxxxxx> <20100611161512.404472115@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 11, 2010 at 12:13:15PM -0400, Christoph Hellwig wrote:
> The writepage implementation in XFS still tries to deal with dirty but
> unmapped buffers which used to caused by writes through shared mmaps.  Since
> the introduction of ->page_mkwrite these can't happen anymore, so remove the
> code dealing with them.
> Note that the all_bh variable which causes us to start I/O on all buffers on
> the pages was controlled by the count of unmapped buffers, which also
> included those not actually dirty.  It's now unconditionally initialized to
> 0 but set to 1 for the case of small file size extensions.  It probably can
> be removed entirely, but that's left for another patch.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>