[Top] [All Lists]

Re: [PATCH 2/3] xfs: simplify xfs_vm_releasepage

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfs: simplify xfs_vm_releasepage
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 15 Jun 2010 11:37:37 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100611161511.791495868@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100611161312.446670249@xxxxxxxxxxxxxxxxxxxxxx> <20100611161511.791495868@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 11, 2010 at 12:13:14PM -0400, Christoph Hellwig wrote:
> Currently the xfs releasepage implementation has code to deal with converting
> delayed allocated and unwritten space.  But we never get called for those as
> we always convert delayed and unwritten space when cleaning a page, or drop
> the state from the buffers in block_invalidatepage.  We still keep a WARN_ON
> on those cases for now, but remove all the case dealing with it, which allows
> to fold xfs_page_state_convert into xfs_vm_writepage and remove the !startio
> case from the whole writeback path.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. Couple of things:

> +
> +     /*
> +      * VM calculation for nr_to_write seems off.  Bump it way
> +      * up, this gets simple streaming writes zippy again.
> +      * To be reviewed again after Jens' writeback changes.
> +      */
> +     wbc->nr_to_write *= 4;
> +

That's gone in mainline as of as of .35-rc3. We need to get the
xfs-dev tree updated.

Otherwise, conѕider it:

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>