xfs
[Top] [All Lists]

Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warni

To: Andi Kleen <andi@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 15 Jun 2010 10:54:42 +1000
Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, dgc@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20100614163122.GB369@xxxxxxxxxxxxxxx>
References: <20100614081356.GA27499@xxxxxxxxxxxxxxx> <20100614083021.GA29354@xxxxxx> <4C15EF75.5080909@xxxxxxxxxxxxxxx> <20100614124804.GA8547@xxxxxx> <20100614133958.GH17092@xxxxxxxxxxxxxxx> <20100614163122.GB369@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jun 14, 2010 at 06:31:22PM +0200, Andi Kleen wrote:
> On Mon, Jun 14, 2010 at 03:39:58PM +0200, Andi Kleen wrote:
> > On Mon, Jun 14, 2010 at 02:48:04PM +0200, Christoph Hellwig wrote:
> > > On Mon, Jun 14, 2010 at 10:59:33AM +0200, Andi Kleen wrote:
> > > > >How can this work?  bp->data is a void pointer.
> > > > 
> > > > It compiled with CONFIG_XFS_DEBUG enabled. Do I need to set some other
> > > > option to test this?
> > > 
> > > It fails for me in a normal CONFIG_XFS_DEBUG build:
> > > 
> > > fs/xfs/xfs_da_btree.c: In function 'xfs_da_root_join':
> > > fs/xfs/xfs_da_btree.c:737: warning: dereferencing 'void *' pointer
> > > fs/xfs/xfs_da_btree.c:737: error: request for member 'magic' in
> > > something not a structure or union
> > > fs/xfs/xfs_da_btree.c:737: warning: dereferencing 'void *' pointer
> > 
> > 
> > Hmm, it really compiled here (scratching head)
> 
> Never mind, it seems SUBDIRS doesn't set the DEBUG flag correctly. 
> 
> Anyways I just dropped those hunks and you'll have to live with 
> the warnings if you don't want QASSERT.

I'm still not happy with it.

We'll commit a modified version of one of your patches into the XFS
tree as you seem unable to accept that changes might be necessary to
get your code to pass review.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>