[Top] [All Lists]

Re: WARNING in xfs_lwr.c, xfs_write()

To: Ilia Mirkin <imirkin@xxxxxxxxxxxx>
Subject: Re: WARNING in xfs_lwr.c, xfs_write()
From: Roman Kononov <roman@xxxxxxxxxxxxxx>
Date: Mon, 14 Jun 2010 10:11:06 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=date:from:to:cc:subject:message-id:in-reply-to:references:mime-version:content-type:content-transfer-encoding; s=smtpout; bh=cLk14249P18sJu/JXpYav1vvUaE=; b=LdN5Yk9j0kdmoIQbQUUBnHTK1yQLGPB65B49UqgIYjAeXtHPuWkj98rhNcauDChcnGSXt07DtrczioK5md4K6dskl0mf/vYL4ixiSXj07OfCse+91SIlg0XzZsRG0AmETNqgvIKu7ZlYqQhkxN5R2cCefpqMgPzPYNcBVE72z5c=
In-reply-to: <AANLkTilqrYxnRzB3FNNE3k3hX2Sp1U63gyTo3T4CIzWV@xxxxxxxxxxxxxx>
References: <20100523002023.41f5a5c8@xxxxxxxxxxxxxxxxxxxxxxx> <20100523101856.GL2150@dastard> <20100523092344.0fcaab42@xxxxxxxxxxxxxxxxxxxxxxx> <20100524011907.GC12087@dastard> <AANLkTinyt6V9phjXrzrxm67THdRwTiN6pOim3uBUbo1Z@xxxxxxxxxxxxxx> <20100613224752.GA2069@dastard> <AANLkTikA2d44tZF1TWZAjCqXkhsw0mzsAIaeCosZLqVq@xxxxxxxxxxxxxx> <20100614012933.GB6590@dastard> <AANLkTilqrYxnRzB3FNNE3k3hX2Sp1U63gyTo3T4CIzWV@xxxxxxxxxxxxxx>
2010-06-13 23:27 CDT, Ilia Mirkin <imirkin@xxxxxxxxxxxx> said:
>Instead it will be "mysql works fine on ext3, but with xfs it spams
>the logs with warnings, therefore xfs must be broken". I don't think
>there's anything realistically that you can do about uninformed users
>and FUD. Although I wasn't suggesting to get rid of the warning,
>rather to make it more explicit as to what it's warning about. I
>interpret a WARN as a BUG that can be recovered but where the
>underlying system needs a careful look; my first inclination after
>seeing a fs-related WARN would be to take the system down and run an
>fsck. What's happening here seems more akin to getting a WARN when
>calling an ioctl with invalid parameters.

I agree. My reaction to this WARN was horrible: I brought the system
down, started fsck-ing and re-installing older kernels, with all kinds
of FUD, which took me considerable time. The message was not well
explained on the Internet, nor was it clear reading the source code.
After talking to the mailing list and investigation of my S/W, I've
realized that the system works fine, and the warning now sounds to me
as useless and unwanted noise of quite high volume.

I am suggesting to issue a notice once per filesytem/mount without
taint. The notice could be as such:

"WARNING: Userspace issues direct IO which races with buffered or mmap
IO on the same file (inode <number>, device <name>). File data
corruption is possible. This message is issued only once per mount".


<Prev in Thread] Current Thread [Next in Thread>