xfs
[Top] [All Lists]

Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused stateme

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Mon, 14 Jun 2010 16:37:20 +0200
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20100614133755.GE6590@dastard>
References: <20100610110.764742110@xxxxxxxxxxxxxx> <20100610111052.3DDC5B1A2B@xxxxxxxxxxxxxxxxxxxx> <20100614042700.GC6590@dastard> <20100614074309.GA17092@xxxxxxxxxxxxxxx> <20100614133755.GE6590@dastard>
User-agent: Mutt/1.5.17 (2007-11-01)
> > > function head comment during development.  Anyway, if we do get an
> > > error here, we cannot handle it anyway - it's too late to do
> > > anything short of a complete shutdown as we've already written the
> > > transaction to the log.
> > 
> > Well I guess it should be unconditional BUG_ON then.
> 
> Don't be silly. A filesystem shutdown is all that is necessary,

Without BUG_ON it will not end up in kerneloops.org and you will
never know about it.  That's standard Linux kernel development
practice.

Maybe XFS should catch up on that.

Ok in principle you could make the shutdown a WARN()

Anyways I'm out of this.

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

<Prev in Thread] Current Thread [Next in Thread>