Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused stateme

To:	Andi Kleen <andi@xxxxxxxxxxxxxx>
Subject:	Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 11 Jun 2010 12:20:07 -0400
Cc:	xfs@xxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<20100610111052.3DDC5B1A2B@xxxxxxxxxxxxxxxxxxxx>
References:	<20100610110.764742110@xxxxxxxxxxxxxx> <20100610111052.3DDC5B1A2B@xxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-08-17)

Most of this looks good to me, but I really don't like the QASSERT
macro.  If you're fine with it I'll split this up into smaller patches
and resubmit the unmodified parts under your name and redo those bits
I don't like.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Christoph Hellwig <= Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Dave Chinner Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Dave Chinner Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Dave Chinner Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Christoph Hellwig Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen

Previous by Date:	Re: linux-2.6.34 xfs crash: xfs_inode_ag_iterator+0x6c - NULL pointer dereference, Christoph Hellwig
Next by Date:	Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen
Previous by Thread:	[PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen
Next by Thread:	Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings, Andi Kleen
Indexes:	[Date] [Thread] [Top] [All Lists]