xfs
[Top] [All Lists]

Re: [PATCH 4/8] Add test of quota accounting using fsx

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 4/8] Add test of quota accounting using fsx
From: Jan Kara <jack@xxxxxxx>
Date: Thu, 10 Jun 2010 12:58:14 +0200
Cc: Jan Kara <jack@xxxxxxx>, xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
In-reply-to: <4C0FD43D.3040803@xxxxxxxxxxx>
References: <1274710459-11446-1-git-send-email-jack@xxxxxxx> <1274710459-11446-5-git-send-email-jack@xxxxxxx> <4C0FD43D.3040803@xxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed 09-06-10 12:49:49, Eric Sandeen wrote:
> Jan Kara wrote:
> > Run fsx (and also several fsx threads in parallel) and verify that
> > quota accounting is correct after they finish.
> 
> Jan, I'm having trouble with this one on XFS for some reason, with our 
> RHEL6 kernel and quota-3.17...
> 
> +Disabling group quota enforcement and accounting on 
> /dev/mapper/VolGroup00-testvol2
> +Disabling user quota enforcement and accounting on 
> /dev/mapper/VolGroup00-testvol2
> +repquota: Mountpoint (or device) /mnt/testarea/scratch not found or has no 
> quota enabled.
> +repquota: Not all specified mountpoints are using quota.
> +repquota: Mountpoint (or device) /mnt/testarea/scratch not found or has no 
> quota enabled.
> +repquota: Not all specified mountpoints are using quota.
> 
> ...
> 
> however if I remove the quotaon calls (off / on settings) in check_usage()
> then it works:
> 
> check_usage()
> {
>         # quotaon -f -u -g $SCRATCH_MNT 2>/dev/null
>         repquota -u -g $SCRATCH_MNT  | grep -v "^root" | filter_scratch \
>                 >$tmp.orig
>         quotacheck -u -g $SCRATCH_MNT 2>/dev/null
>         repquota -u -g $SCRATCH_MNT  | grep -v "^root" | filter_scratch \
>                 >$tmp.checked
>         # quotaon -u -g $SCRATCH_MNT 2>/dev/null
>         diff $tmp.orig $tmp.checked
> }
> 
> 
> Seems like 2 issues: noisy disable messages, and repquota failing when 
> disabled.
  I've fixed noisy disable messages in quotaon (without -v flag only errors
should be printed) in CVS. With repquota & disabled quotas it's a bit more
complicated. The problem is that for ext?, reiserfs,... you have to disable
quotas before running quotacheck. Also quotacheck is NOP for XFS - we'd
rather need to call something to really recompute quota usage for XFS. How
that can be done?

                                                                        Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>