xfs
[Top] [All Lists]

Re: [PATCH] xfstests 217: remove file in between mkfs's

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 217: remove file in between mkfs's
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 9 Jun 2010 09:25:36 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4C0F0A4C.7050600@xxxxxxxxxxx>
References: <4C0F0A4C.7050600@xxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Jun 08, 2010 at 10:28:12PM -0500, Eric Sandeen wrote:
> 217 requires a 2G scratch:
> 
> _require_fs_space $SCRATCH_MNT 2202000
> 
> but as we mkfs different sizes, we actually are filling in the
> sparse loopback more and more, and 3.8G isn't enough to contain it.
> 
> If we remove & recreate the file between mkfs's it doesn't take
> so much space ... I don't think it adds significantly to test time.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>