[Top] [All Lists]

Re: [PATCH 3/6] writeback: Add tracing to write_cache_pages

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] writeback: Add tracing to write_cache_pages
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 4 Jun 2010 03:51:27 -0400
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx
In-reply-to: <1275609328-12514-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1275609328-12514-1-git-send-email-david@xxxxxxxxxxxxx> <1275609328-12514-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, Jun 04, 2010 at 09:55:25AM +1000, Dave Chinner wrote:
> Add a trace event to the ->writepage loop in write_cache_pages to give
> visibility into how the ->writepage call is changing variables within the
> writeback control structure. Of most interest is how wbc->nr_to_write changes
> from call to call, especially with filesystems that write multiple pages
> in ->writepage.

Looks good, it might be worth to add another tracepoint for ->writepage
from reclaim context so that we can start investigating the cases where
that happens far too often.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>