xfs
[Top] [All Lists]

Re: [PATCH 02/17] xfs: skip writeback from reclaim context

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/17] xfs: skip writeback from reclaim context
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 2 Jun 2010 06:08:12 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20100602043957.GB7011@dastard>
References: <20100531160727.842750532@xxxxxxxxxxxxxxxxxxxxxx> <20100531160859.184576507@xxxxxxxxxxxxxxxxxxxxxx> <20100602043957.GB7011@dastard>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Jun 02, 2010 at 02:39:57PM +1000, Dave Chinner wrote:
> Also worth thinking about is if should be checked in
> xfs_vm_releasepage() as well to avoid the same stack issues if it
> triggers allocation...

I agree this is a potential problem as well.

I did some QA runs with this thrown in, and it causes massive OOM killer
wreckage in xfstests.  I've also cross-checked btrfs and ext4 and
neither one skips ->releasepage from reclaim context.

<Prev in Thread] Current Thread [Next in Thread>