xfs
[Top] [All Lists]

Re: [PATCH 17/17] xfs: remove unused delta tracking code in xfs_bmapi

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 17/17] xfs: remove unused delta tracking code in xfs_bmapi
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 2 Jun 2010 16:11:37 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100531160902.541889062@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100531160727.842750532@xxxxxxxxxxxxxxxxxxxxxx> <20100531160902.541889062@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, May 31, 2010 at 12:07:44PM -0400, Christoph Hellwig wrote:
> This code was introduced four years ago in commit
> 3e57ecf640428c01ba1ed8c8fc538447ada1715b without any review and has
> been unused since.  Remove it just as the rest of the code introduced
> in that commit to reduce that stack usage and complexity in this central
> piece of code.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Agreed. if we have need for it in the future, it's there in
revision history.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 17/17] xfs: remove unused delta tracking code in xfs_bmapi, Dave Chinner <=