[Top] [All Lists]

Re: [PATCH 10/17] xfs: simplify buffer pinning

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/17] xfs: simplify buffer pinning
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 2 Jun 2010 15:47:41 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100531160901.186403532@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100531160727.842750532@xxxxxxxxxxxxxxxxxxxxxx> <20100531160901.186403532@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, May 31, 2010 at 12:07:37PM -0400, Christoph Hellwig wrote:
> Get rid of the xfs_buf_pin/xfs_buf_unpin/xfs_buf_ispin helpers and opencode
> them in their only callers, just like we did for the inode pinning a while
> ago.  Also remove duplicate trace points - the bufitem tracepoints cover
> all the information that is present in a buffer tracepoint.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 10/17] xfs: simplify buffer pinning, Dave Chinner <=