[Top] [All Lists]

Re: [PATCH 04/17] xfs: drop dmapi hooks

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/17] xfs: drop dmapi hooks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 2 Jun 2010 14:45:14 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100531160859.618170031@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100531160727.842750532@xxxxxxxxxxxxxxxxxxxxxx> <20100531160859.618170031@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, May 31, 2010 at 12:07:31PM -0400, Christoph Hellwig wrote:
> Dmapi support was never merged upstream, but we still have a lot of hooks
> bloating XFS for it, all over the fast pathes of the filesystem.
> This patch drops over 700 lines of dmapi overhead.  If we'll ever get HSM
> support in mainline at least the namespace events can be done much saner
> in the VFS instead of the individual filesystem, so it's not like this
> is much help for future work.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks pretty good to me, and it runs through QA just fine.
There are still a couple of references to dmapi in comments,
but I don't think that's a big issue.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 04/17] xfs: drop dmapi hooks, Dave Chinner <=