xfs
[Top] [All Lists]

Re: [PATCH 11/17] fs/xfs/quota: Add missing mutex_unlock

To: Julia Lawall <julia@xxxxxxx>
Subject: Re: [PATCH 11/17] fs/xfs/quota: Add missing mutex_unlock
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 28 May 2010 12:57:32 -0500
Cc: xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.64.1005261757050.23743@xxxxxxxxxxx>
References: <Pine.LNX.4.64.1005261757050.23743@xxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-05-26 at 17:57 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
> 
> Add a mutex_unlock missing on the error path.  The use of this lock is
> balanced elsewhere in the file.

Looks good.  I'll pull this one into the XFS tree.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression E1;
> @@
> 
> * mutex_lock(E1,...);
>   <+... when != E1
>   if (...) {
>     ... when != E1
> *   return ...;
>   }
>   ...+>
> * mutex_unlock(E1,...);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@xxxxxxx>
> 
> ---
> The use of ENOMEM rather than -ENOMEM is also a bit odd.
> 
>  fs/xfs/quota/xfs_qm.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c
> index 38e7641..2d8b7bc 100644
> --- a/fs/xfs/quota/xfs_qm.c
> +++ b/fs/xfs/quota/xfs_qm.c
> @@ -249,8 +249,10 @@ xfs_qm_hold_quotafs_ref(
>  
>       if (!xfs_Gqm) {
>               xfs_Gqm = xfs_Gqm_init();
> -             if (!xfs_Gqm)
> +             if (!xfs_Gqm) {
> +                     mutex_unlock(&xfs_Gqm_lock);
>                       return ENOMEM;
> +             }
>       }
>  
>       /*



<Prev in Thread] Current Thread [Next in Thread>