[Top] [All Lists]

Re: [PATCH 1/2 v2] xfs: drop dmapi hooks

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2 v2] xfs: drop dmapi hooks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 26 May 2010 16:12:26 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100525094524.GA1647@xxxxxxxxxxxxx>
References: <20100510140823.GA16540@xxxxxxxxxxxxx> <20100525094524.GA1647@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, May 25, 2010 at 05:45:24AM -0400, Christoph Hellwig wrote:
> Dmapi support was never merged upstream, but we still have a lot of hooks
> bloating XFS for it, all over the fast pathes of the filesystem.
> This patch drops over 700 lines of dmapi overhead.  If we'll ever get HSM
> support in mainline at least the namespace events can be done much saner
> in the VFS instead of the individual filesystem, so it's not like this
> is much help for future work.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>