[Top] [All Lists]

Re: [PATCH 3/6] ext4: Use our own write_cache_pages()

To: tytso@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, jens.axboe@xxxxxxxxxx
Subject: Re: [PATCH 3/6] ext4: Use our own write_cache_pages()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 26 May 2010 08:42:59 +1000
In-reply-to: <20100525130626.GD5556@xxxxxxxxx>
References: <1274784852-30502-1-git-send-email-david@xxxxxxxxxxxxx> <1274784852-30502-4-git-send-email-david@xxxxxxxxxxxxx> <20100525130626.GD5556@xxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, May 25, 2010 at 09:06:26AM -0400, tytso@xxxxxxx wrote:
> On Tue, May 25, 2010 at 08:54:09PM +1000, Dave Chinner wrote:
> > From: Theodore Ts'o <tytso@xxxxxxx>
> > 
> > Make a copy of write_cache_pages() for the benefit of
> > ext4_da_writepages().  This allows us to simplify the code some, and
> > will allow us to further customize the code in future patches.
> I'm going to be pushing this to Linus shortly, so it's likely you'll
> be able to drop this from your patch series.


> I just wanted to give
> you a heads up about what I was planning on doing, which hopefully
> simplified your life a little.

And that's appreciated. I included it to make sure everyone could
see how this all fitted together and others could test it if they so
desired. i.e. make sure I wasn't breaking ext4 by reverting the
changes to write_cache_pages. I'll leave it in the series until the
ext4 change is upstream, then I'll drop it.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>