Re: [PATCH 5/6] xfs: remove nr_to_write writeback windup.

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 5/6] xfs: remove nr_to_write writeback windup.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 25 May 2010 07:14:14 -0400
Cc:	linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, tytso@xxxxxxx, jens.axboe@xxxxxxxxxx
In-reply-to:	<1274784852-30502-6-git-send-email-david@xxxxxxxxxxxxx>
References:	<1274784852-30502-1-git-send-email-david@xxxxxxxxxxxxx> <1274784852-30502-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Tue, May 25, 2010 at 08:54:11PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Now that the background flush code has been fixed, we shouldn't need to
> silently multiply the wbc->nr_to_write to get good writeback. Remove
> that code.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Ok,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 3/6] ext4: Use our own write_cache_pages(), (continued) Re: [PATCH 3/6] ext4: Use our own write_cache_pages(), tytso Re: [PATCH 3/6] ext4: Use our own write_cache_pages(), Dave Chinner [PATCH 1/6] writeback: initial tracing support, Dave Chinner Re: [PATCH 1/6] writeback: initial tracing support, Christoph Hellwig Re: [PATCH 1/6] writeback: initial tracing support, Andrew Morton Re: [PATCH 1/6] writeback: initial tracing support, Dave Chinner Re: [PATCH 1/6] writeback: initial tracing support, Steven Rostedt Re: [PATCH 1/6] writeback: initial tracing support, Steven Rostedt Re: [PATCH 1/6] writeback: initial tracing support, Christoph Hellwig [PATCH 5/6] xfs: remove nr_to_write writeback windup., Dave Chinner Re: [PATCH 5/6] xfs: remove nr_to_write writeback windup., Christoph Hellwig <= [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF, Dave Chinner Re: [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF, Andrew Morton Re: [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF, Dave Chinner Re: [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF, Nick Piggin [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages, Dave Chinner Re: [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages, Christoph Hellwig Re: [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages, Andrew Morton Re: [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages, Dave Chinner

Previous by Date:	Re: [PATCH 2/6] writeback: Add tracing to balance_dirty_pages, Christoph Hellwig
Next by Date:	Re: Is persistant preallocation possible?, Roger Willcocks
Previous by Thread:	[PATCH 5/6] xfs: remove nr_to_write writeback windup., Dave Chinner
Next by Thread:	[PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]