xfs
[Top] [All Lists]

Re: [PATCH 1/6] writeback: initial tracing support

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] writeback: initial tracing support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 25 May 2010 07:13:26 -0400
Cc: linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, tytso@xxxxxxx, jens.axboe@xxxxxxxxxx
In-reply-to: <1274784852-30502-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1274784852-30502-1-git-send-email-david@xxxxxxxxxxxxx> <1274784852-30502-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/writeback.h>

It might be worth to add a comment why this is in an unusal place.

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>