[Top] [All Lists]

Re: [PATCH 09/12] xfs: Introduce delayed logging core code

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/12] xfs: Introduce delayed logging core code
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 21 May 2010 16:06:03 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1274138668-1662-10-git-send-email-david@xxxxxxxxxxxxx>
References: <1274138668-1662-1-git-send-email-david@xxxxxxxxxxxxx> <1274138668-1662-10-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2010-05-18 at 09:24 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> The delayed logging code only changes in-memory structures and as
> such can be enabled and disabled with a mount option. Add the mount
> option and emit a warning that this is an experimental feature that
> should not be used in production yet.

I gave this a careful review.  I am a little surprised at
how nicely you could stitch this in, leveraging the existing
code, while still supporting the "old" logging model.

Anyway, I found some nits but no bugs so I'm not going
to bother mentioning them here.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

. . .

> the necessary synchronisation for correct operation in both cases.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> ---

<Prev in Thread] Current Thread [Next in Thread>