xfs
[Top] [All Lists]

Re: [PATCH 4/7] Add test of quota accounting using fsx

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/7] Add test of quota accounting using fsx
From: Jan Kara <jack@xxxxxxx>
Date: Thu, 20 May 2010 14:52:34 +0200
Cc: Jan Kara <jack@xxxxxxx>, xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
In-reply-to: <20100519222813.GN8120@dastard>
References: <1274276289-8839-1-git-send-email-jack@xxxxxxx> <1274276289-8839-5-git-send-email-jack@xxxxxxx> <20100519222813.GN8120@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu 20-05-10 08:28:13, Dave Chinner wrote:
> On Wed, May 19, 2010 at 03:38:06PM +0200, Jan Kara wrote:
> > Run fsx (and also several fsx threads in parallel) and verify that
> > quota accounting is correct after they finish.
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > ---
> >  231     |  139 
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  231.out |   10 +++++
> >  group   |    1 +
> >  3 files changed, 150 insertions(+), 0 deletions(-)
> >  create mode 100755 231
> >  create mode 100644 231.out
> > 
> > diff --git a/231 b/231
> > new file mode 100755
> > index 0000000..0e34d33
> > --- /dev/null
> > +++ b/231
> > @@ -0,0 +1,139 @@
> > +#! /bin/bash
> > +# FSQA Test No. 231
> > +#
> > +# Run fsx with quotas enabled and verify accounted quotas in the end
> > +#
> > +# Derived from test 127
> > +#-----------------------------------------------------------------------
> > +# Copyright (c) 2006 Silicon Graphics, Inc.  All Rights Reserved.
> > +#
> > +# This program is free software; you can redistribute it and/or
> > +# modify it under the terms of the GNU General Public License as
> > +# published by the Free Software Foundation.
> > +#
> > +# This program is distributed in the hope that it would be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +# GNU General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program; if not, write the Free Software Foundation,
> > +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> > +#
> > +#-----------------------------------------------------------------------
> > +#
> > +# creator
> > +owner=jack@xxxxxxx
> > +
> > +seq=`basename $0`
> > +echo "QA output created by $seq"
> > +
> > +here=`pwd`
> > +tmp=/tmp/$$
> > +status=1   # failure is the default!
> > +trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
> > +
> > +# get standard environment, filters and checks
> > +. ./common.rc
> > +. ./common.filter
> > +. ./common.quota
> > +
> > +FSX_FILE_SIZE=64000000
> > +FSX_ARGS="-q -l $FSX_FILE_SIZE -o 65536 -S 191110531 -N 20000"
> 
> My only question about this test is the use of a fixed seed for the
> test - shouldn't we randomise it and save the seed to $seq.full?
> This will results in different combinations of operations being
> tested (better long term coverage), but we still have the seed
> available to try to reproduce failures if they are based on a
> specific pattern of ops...
  Ah, that's a great idea. I wanted a reproducible testcase so I
chose fixed seed but I forgot I could save it in $seq.full. I'll
change the test to work this way.

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>