Re: [PATCH 11/12] xfs: enable background pushing of the CIL

xfs

Re: [PATCH 11/12] xfs: enable background pushing of the CIL

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 11/12] xfs: enable background pushing of the CIL
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 10 May 2010 07:45:57 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1273210860-23414-12-git-send-email-david@xxxxxxxxxxxxx>
References:	<1273210860-23414-1-git-send-email-david@xxxxxxxxxxxxx> <1273210860-23414-12-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Fri, May 07, 2010 at 03:40:59PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> If we let the CIL grow without bound, it will grow large enough to violate
> recovery constraints (must be at least one complete transaction in the log at
> all times) or take forever to write out through the log buffers. Hence we need
> a check during asynchronous transactions as to whether the CIL needs to be
> pushed.
> 
> We track the amount of log space the CIL consumes, so it is relatively simple
> to limit it on a pure size basis. Make the limit the minimum of just under 
> half
> the log size (recovery constraint) or 8MB of log space (which is an awful lot
> of metadata).

Looks good except for the use of a cleanup label in xlog_cil_push
mention in the review of the main patch.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/12] xfs: delayed logging V5, Dave Chinner [PATCH 01/12] xfs: Don't reuse the same transaction ID for duplicated transactions., Dave Chinner [PATCH 05/12] xfs: clean up log ticket overrun debug output, Dave Chinner [PATCH 06/12] xfs: make the log ticket ID available outside the log infrastructure, Dave Chinner Re: [PATCH 06/12] xfs: make the log ticket ID available outside the log infrastructure, Christoph Hellwig [PATCH 02/12] xfs: allow log ticket allocation to take allocation flags, Dave Chinner *[PATCH 04/12] xfs: Clean up XFS_BLI_ flag namespace*, Dave Chinner* [PATCH 11/12] xfs: enable background pushing of the CIL, Dave Chinner Re: [PATCH 11/12] xfs: enable background pushing of the CIL, Christoph Hellwig <= [PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed, Dave Chinner Re: [PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed, Christoph Hellwig [PATCH 10/12] xfs: forced unmounts need to push the CIL, Dave Chinner Re: [PATCH 10/12] xfs: forced unmounts need to push the CIL, Christoph Hellwig [PATCH 07/12] xfs: Improve scalability of busy extent tracking, Dave Chinner Re: [PATCH 07/12] xfs: Improve scalability of busy extent tracking, Christoph Hellwig [PATCH 08/12] xfs: Delayed logging design documentation, Dave Chinner [PATCH 03/12] xfs: modify buffer item reference counting, Dave Chinner [PATCH 09/12] xfs: Introduce delayed logging core code, Dave Chinner Re: [PATCH 09/12] xfs: Introduce delayed logging core code, Christoph Hellwig

Previous by Date:	Re: [PATCH 10/12] xfs: forced unmounts need to push the CIL, Christoph Hellwig
Next by Date:	Re: [PATCH 09/12] xfs: Introduce delayed logging core code, Dave Chinner
Previous by Thread:	[PATCH 11/12] xfs: enable background pushing of the CIL, Dave Chinner
Next by Thread:	[PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]