[Top] [All Lists]

Re: [PATCH 11/12] xfs: enable background pushing of the CIL

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/12] xfs: enable background pushing of the CIL
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 10 May 2010 07:45:57 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1273210860-23414-12-git-send-email-david@xxxxxxxxxxxxx>
References: <1273210860-23414-1-git-send-email-david@xxxxxxxxxxxxx> <1273210860-23414-12-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, May 07, 2010 at 03:40:59PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> If we let the CIL grow without bound, it will grow large enough to violate
> recovery constraints (must be at least one complete transaction in the log at
> all times) or take forever to write out through the log buffers. Hence we need
> a check during asynchronous transactions as to whether the CIL needs to be
> pushed.
> We track the amount of log space the CIL consumes, so it is relatively simple
> to limit it on a pure size basis. Make the limit the minimum of just under 
> half
> the log size (recovery constraint) or 8MB of log space (which is an awful lot
> of metadata).

Looks good except for the use of a cleanup label in xlog_cil_push
mention in the review of the main patch.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>