xfs
[Top] [All Lists]

Re: [PATCH 06/12] xfs: make the log ticket ID available outside the log

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/12] xfs: make the log ticket ID available outside the log infrastructure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 7 May 2010 07:41:30 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1273210860-23414-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1273210860-23414-1-git-send-email-david@xxxxxxxxxxxxx> <1273210860-23414-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, May 07, 2010 at 03:40:54PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The ticket ID is needed to uniquely identify transactions when doing busy
> extent matching. Delayed logging changes the lifecycle of busy extents with
> respect to the transaction structure lifecycle. Hence we can no longer use
> the transaction structure as a means of determining the owner of the busy
> extent as it may be freed and reused while the busy extent is still active.
> 
> This commit provides the infrastructure to access the xlog_tid_t held in the
> ticket from a transaction handle. This avoids the need for callers to peek
> into the transaction and log structures to find this out.

No happy about exposing the tid, but given that we need it for now:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>