[Top] [All Lists]

[PATCH 01/12] xfs: Don't reuse the same transaction ID for duplicated tr

To: xfs@xxxxxxxxxxx
Subject: [PATCH 01/12] xfs: Don't reuse the same transaction ID for duplicated transactions.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 7 May 2010 15:40:49 +1000
In-reply-to: <1273210860-23414-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1273210860-23414-1-git-send-email-david@xxxxxxxxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

The transaction ID is written into the log as the unique identifier
for transactions during recover. When duplicating a transaction, we
reuse the log ticket, which means it has the same transaction ID as
the previous transaction.

Rather than regenerating a random transaction ID for the duplicated
transaction, just add one to the current ID so that duplicated
transaction can be easily spotted in the log and during recovery
during problem diagnosis.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
 fs/xfs/xfs_log.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 3038dd5..687b220 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -360,6 +360,15 @@ xfs_log_reserve(
                ASSERT(flags & XFS_LOG_PERM_RESERV);
                internal_ticket = *ticket;
+               /*
+                * this is a new transaction on the ticket, so we need to
+                * change the transaction ID so that the next transaction has a
+                * different TID in the log. Just add one to the existing tid
+                * so that we can see chains of rolling transactions in the log
+                * easily.
+                */
+               internal_ticket->t_tid++;
                trace_xfs_log_reserve(log, internal_ticket);
                xlog_grant_push_ail(mp, internal_ticket->t_unit_res);

<Prev in Thread] Current Thread [Next in Thread>