Re: [PATCH 05/11] xfs: Clean up XFS_BLI

xfs

Re: [PATCH 05/11] xfs: Clean up XFS_BLI_* flag namespace

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 05/11] xfs: Clean up XFS_BLI_* flag namespace
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 6 May 2010 16:51:58 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1273110351-2333-6-git-send-email-david@xxxxxxxxxxxxx>
References:	<1273110351-2333-1-git-send-email-david@xxxxxxxxxxxxx> <1273110351-2333-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Thu, May 06, 2010 at 11:45:45AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Clean up the buffer log format (XFS_BLI_*) flags because they have a
> polluted namespace. They XFS_BLI_ prefix is used for both in-memory
> and on-disk flag feilds, but have overlapping values for different
> flags. Rename the buffer log format flags to use the XFS_BLF_*
> prefix to avoid confusing them with the in-memory XFS_BLI_* prefixed
> flags.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/11] xfs: delayed logging, Dave Chinner *[PATCH 05/11] xfs: Clean up XFS_BLI_ flag namespace*, Dave Chinner* *Re: [PATCH 05/11] xfs: Clean up XFS_BLI_ flag namespace*, Christoph Hellwig* <= [PATCH 01/11] xfs: Don't reuse the same transaciton ID for duplicated transactions., Dave Chinner Re: [PATCH 01/11] xfs: Don't reuse the same transaciton ID for duplicated transactions., Christoph Hellwig [PATCH 03/11] xfs: allow log ticket allocation to take allocation flags, Dave Chinner Re: [PATCH 03/11] xfs: allow log ticket allocation to take allocation flags, Christoph Hellwig [PATCH 09/11] xfs: forced unmounts need to push the CIL, Dave Chinner [PATCH 02/11] xfs: Improve scalability of busy extent tracking, Dave Chinner [PATCH 08/11] xfs: Introduce delayed logging core code, Dave Chinner [PATCH 06/11] xfs: clean up log ticket overrun debug output, Dave Chinner Re: [PATCH 06/11] xfs: clean up log ticket overrun debug output, Christoph Hellwig [PATCH 10/11] xfs: enable background pushing of the CIL, Dave Chinner

Previous by Date:	Re: [PATCH 06/11] xfs: clean up log ticket overrun debug output, Christoph Hellwig
Next by Date:	Re: [PATCH 04/11] xfs: modify buffer item reference counting V2, Christoph Hellwig
Previous by Thread:	*[PATCH 05/11] xfs: Clean up XFS_BLI_ flag namespace*, Dave Chinner*
Next by Thread:	[PATCH 01/11] xfs: Don't reuse the same transaciton ID for duplicated transactions., Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]