xfs
[Top] [All Lists]

Re: [PATCH 05/11] xfs: Clean up XFS_BLI_* flag namespace

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/11] xfs: Clean up XFS_BLI_* flag namespace
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 May 2010 16:51:58 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1273110351-2333-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1273110351-2333-1-git-send-email-david@xxxxxxxxxxxxx> <1273110351-2333-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, May 06, 2010 at 11:45:45AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Clean up the buffer log format (XFS_BLI_*) flags because they have a
> polluted namespace. They XFS_BLI_ prefix is used for both in-memory
> and on-disk flag feilds, but have overlapping values for different
> flags. Rename the buffer log format flags to use the XFS_BLF_*
> prefix to avoid confusing them with the in-memory XFS_BLI_* prefixed
> flags.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>