xfs
[Top] [All Lists]

Re: [PATCH 01/11] xfs: Don't reuse the same transaciton ID for duplicate

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/11] xfs: Don't reuse the same transaciton ID for duplicated transactions.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 May 2010 16:41:15 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1273110351-2333-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1273110351-2333-1-git-send-email-david@xxxxxxxxxxxxx> <1273110351-2333-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, May 06, 2010 at 11:45:41AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The transaction ID is written into the log as the unique identifier
> for transactions during recover. When duplicating a transaction, we
> reuse the log ticket, which means it has the same transaction ID as
> the previous transaction.
> 
> Rather than regenerating a random transaction ID for the duplicated
> transaction, just add one to the current ID so that duplicated
> transaction can be easily spotted in the log and during recovery
> during problem diagnosis.

Oh well, more fun with transaction ids.  I'm still not happy with
the not guarnateed unique schemes we have here, but for now this should
do it.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>