xfs
[Top] [All Lists]

Re: [PATCH] xfstests: honor comments in the test group file

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: honor comments in the test group file
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 May 2010 16:37:02 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201005061726.o46HQ78v018283@xxxxxxxxxxxxxxxxxxxxxx>
References: <201005061726.o46HQ78v018283@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, May 06, 2010 at 12:26:07PM -0500, Alex Elder wrote:
> (Re-posting unchanged in hopes it will get reviewed this time.)
> 
> There are some spots in the "group" file where test numbers have
> groups listed after a '#' character, clearly intending for those
> groups to be commented out.  But the way the group list gets
> generated that commenting doesn't work, and in fact these tests
> explicitly *are* included in such commented-out groups.
> 
> This patch fixes that, stripping out all comments (which start
> with a '#' character and end with a newline) from the file before
> building the set of test numbers for a group.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>