[Top] [All Lists]

[PATCH] xfstests: honor comments in the test group file

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfstests: honor comments in the test group file
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 06 May 2010 12:26:07 -0500
User-agent: Heirloom mailx 12.4 7/29/08
(Re-posting unchanged in hopes it will get reviewed this time.)

There are some spots in the "group" file where test numbers have
groups listed after a '#' character, clearly intending for those
groups to be commented out.  But the way the group list gets
generated that commenting doesn't work, and in fact these tests
explicitly *are* included in such commented-out groups.

This patch fixes that, stripping out all comments (which start
with a '#' character and end with a newline) from the file before
building the set of test numbers for a group.

Signed-off-by: Alex Elder <aelder@xxxxxxx>

common |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Index: b/common
--- a/common
+++ b/common
@@ -58,9 +58,10 @@ do
     if $group
        # arg after -g
-       group_list=`sed -n <group -e 's/$/ /' -e "/^[0-9][0-9][0-9].* $r /"'{
-s/ .*//p
+       group_list=$(sed -n < group \
+                       -e 's/#.*//' \
+                       -e 's/$/ /' \
+                       -e "/^[0-9][0-9][0-9].* $r /"'{ s/ .*//p }')
        if [ -z "$group_list" ]
            echo "Group \"$r\" is empty or not defined?"

<Prev in Thread] Current Thread [Next in Thread>