xfs
[Top] [All Lists]

Re: [PATCH] xfs: be more explicit if RT mount fails due to config

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: be more explicit if RT mount fails due to config
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 30 Apr 2010 12:40:02 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4BDA54A4.3040204@xxxxxxxxxxx>
References: <4BDA54A4.3040204@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
> +     if (mp->m_sb.sb_rblocks == 0)
> +             return 0;
> +     else {
> +             cmn_err(CE_WARN, "XFS: Not built with CONFIG_XFS_RT");
> +             return ENOSYS;
> +     }

No need for the else if you return anyway.

Looks good either way,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>