xfs
[Top] [All Lists]

Re: [PATCH] xfs: replace E2BIG with EFBIG where appropriate

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: replace E2BIG with EFBIG where appropriate
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 30 Apr 2010 12:39:27 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4BDA51B9.4010501@xxxxxxxxxxx>
References: <4BDA51B9.4010501@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Apr 29, 2010 at 10:42:49PM -0500, Eric Sandeen wrote:
> Many places in the xfs code return E2BIG when they really
> mean EFBIG; trying to grow past 16T on a 32 bit machine,
> for example, says "Argument list too long" rather than "File
> too large" which is not particularly helpful.
> 
> Some of these don't make perfect sense as EFBIG either,
> but still better than E2BIG IMHO.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>