xfs
[Top] [All Lists]

Re: [PATCH 09/11] xfs: clean up mapping size calculation in __xfs_get_bl

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/11] xfs: clean up mapping size calculation in __xfs_get_blocks
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 29 Apr 2010 15:32:30 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100428123016.152412458@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx> <20100428123016.152412458@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-iomap-cleanup-10)
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.  I do think the result of your cleanups is
cleaner looking code.  I worry (a little bit) that
some of the information embedded in some things (like
macro names, e.g. XFS_FSB_TO_B()) going away makes
the code less understandable by someone unfamiliar
with it.  Nevertheless...

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Index: xfs/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================


<Prev in Thread] Current Thread [Next in Thread>