Re: [PATCH 08/11] xfs: clean up xfs_iomap

xfs

Re: [PATCH 08/11] xfs: clean up xfs_iomap_valid

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 08/11] xfs: clean up xfs_iomap_valid
From:	Alex Elder <aelder@xxxxxxx>
Date:	Thu, 29 Apr 2010 15:15:38 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20100428123015.969557658@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx> <20100428123015.969557658@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	aelder@xxxxxxx

On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-iomap-cleanup-9)
> Rename all iomap_valid identifiers to imap_valid to fit the new world order,
> and clean up xfs_iomap_valid to convert the passed in offset to blocks
> instead of the imap values to bytes.  Use the simpler inode->i_blkbits
> instead of the XFS macros for this.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Index: xfs/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 09/11] xfs: clean up mapping size calculation in __xfs_get_blocks, (continued) Re: [PATCH 09/11] xfs: clean up mapping size calculation in __xfs_get_blocks, Alex Elder [PATCH 02/11] xfs: remove iomap_target, Christoph Hellwig Re: [PATCH 02/11] xfs: remove iomap_target, Alex Elder [PATCH 07/11] xfs: move I/O type flags into xfs_aops.c, Christoph Hellwig Re: [PATCH 07/11] xfs: move I/O type flags into xfs_aops.c, Alex Elder [PATCH 10/11] xfs: clean up end index calculation in xfs_page_state_convert, Christoph Hellwig Re: [PATCH 10/11] xfs: clean up end index calculation in xfs_page_state_convert, Alex Elder [PATCH 11/11] xfs: mark xfs_iomap_write_ helpers static, Christoph Hellwig Re: [PATCH 11/11] xfs: mark xfs_iomap_write_ helpers static, Alex Elder [PATCH 08/11] xfs: clean up xfs_iomap_valid, Christoph Hellwig Re: [PATCH 08/11] xfs: clean up xfs_iomap_valid, Alex Elder <= Re: [PATCH 00/11] remove xfs_iomap, Dave Chinner

Previous by Date:	Re: [PATCH 07/11] xfs: move I/O type flags into xfs_aops.c, Alex Elder
Next by Date:	Re: [PATCH 09/11] xfs: clean up mapping size calculation in __xfs_get_blocks, Alex Elder
Previous by Thread:	[PATCH 08/11] xfs: clean up xfs_iomap_valid, Christoph Hellwig
Next by Thread:	Re: [PATCH 00/11] remove xfs_iomap, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]