[Top] [All Lists]

Re: [PATCH 08/11] xfs: clean up xfs_iomap_valid

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/11] xfs: clean up xfs_iomap_valid
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 29 Apr 2010 15:15:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100428123015.969557658@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx> <20100428123015.969557658@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-iomap-cleanup-9)
> Rename all iomap_valid identifiers to imap_valid to fit the new world order,
> and clean up xfs_iomap_valid to convert the passed in offset to blocks
> instead of the imap values to bytes.  Use the simpler inode->i_blkbits
> instead of the XFS macros for this.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Index: xfs/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================

<Prev in Thread] Current Thread [Next in Thread>