xfs
[Top] [All Lists]

Re: [PATCH 04/11] xfs: report iomap_offset and iomap_bsize in block base

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/11] xfs: report iomap_offset and iomap_bsize in block base
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 29 Apr 2010 09:32:47 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100428123015.107986898@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx> <20100428123015.107986898@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-iomap-cleanup-4)
> Report the iomap_offset and iomap_bsize fields of struct xfs_iomap
> in terms of fsblocks instead of in terms of bytes.  Shift the byte
> conversions into the callers temporarily, but they will disappear
> or get cleaned up later.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


> Index: xfs/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_aops.c      2010-04-27 17:07:53.000000000 
> +0200
> +++ xfs/fs/xfs/linux-2.6/xfs_aops.c   2010-04-27 17:13:15.434005637 +0200
. . .


<Prev in Thread] Current Thread [Next in Thread>