[Top] [All Lists]

Re: [PATCH 02/11] xfs: remove iomap_target

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/11] xfs: remove iomap_target
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 29 Apr 2010 09:25:14 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100428123014.699705209@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx> <20100428123014.699705209@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-iomap-cleanup-2)
> Instead of using the iomap_target field in struct xfs_iomap and the
> IOMAP_REALTIME flag just use the already existing xfs_find_bdev_for_inode
> helper.  There's some fallout as we need to pass the inode in a few more
> places, which we also use to sanitize some calling conventions.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

There are other places the xfs_find_bdev_for_inode() helper ought
to be used also.

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Index: xfs/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
. . .

<Prev in Thread] Current Thread [Next in Thread>