xfs
[Top] [All Lists]

Re: [PATCH 01/11] xfs: limit xfs_imap_to_bmap to a single mapping

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 01/11] xfs: limit xfs_imap_to_bmap to a single mapping
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 29 Apr 2010 08:55:13 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100428123014.517888577@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx> <20100428123014.517888577@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-iomap-cleanup-1)
> We only call xfs_iomap for single mappings anyway, so remove all code
> dealing with multiple mappings from xfs_imap_to_bmap and add asserts
> that we never get results that we do not expect.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Index: xfs/fs/xfs/xfs_iomap.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_iomap.c       2010-04-28 14:06:53.000000000 +0200
> +++ xfs/fs/xfs/xfs_iomap.c    2010-04-28 14:14:38.708003332 +0200

. . .

<Prev in Thread] Current Thread [Next in Thread>