| To: | Tao Ma <tao.ma@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: Add query fiemap count test. |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 29 Apr 2010 15:35:14 +1000 |
| Cc: | xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Alex Elder <aelder@xxxxxxx> |
| In-reply-to: | <1272437450-4654-1-git-send-email-tao.ma@xxxxxxxxxx> |
| References: | <20100428015035.GC9783@dastard> <1272437450-4654-1-git-send-email-tao.ma@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Wed, Apr 28, 2010 at 02:50:50PM +0800, Tao Ma wrote: > According to Documentation/filesystems/fiemap.txt, If fm_extent_count > is zero, then the fm_extents[] array is ignored (no extents will be > returned), and the fm_mapped_extents count will hold the number of > extents needed. > > This is broken by commit 97db39a1f6f69e906e98118392400de5217aa33a. > So add this test case in fiemap tester to avoid future regression. > > Cc: Dave Chinner <david@xxxxxxxxxxxxx> > Cc: Eric Sandeen <sandeen@xxxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Alex Elder <aelder@xxxxxxx> > Signed-off-by: Tao Ma <tao.ma@xxxxxxxxxx> Looks ok. Just running for a test and if I don't see any problems, then I'll check it in. Thanks for the fix and the test, Tao. ;) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [GIT PULL] fixes for 2.6.34-rc6, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 3/3] xfsqa: build dbtest on debian platforms, Dave Chinner |
| Previous by Thread: | [PATCH] xfstests: Add query fiemap count test., Tao Ma |
| Next by Thread: | [PATCH] xfs: cleanup log reservation calculactions, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |