xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: write both features2 fields when xfs_admin changes

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: write both features2 fields when xfs_admin changes lazy_count
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 29 Apr 2010 12:28:25 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Marcin Mirosław <marcin@xxxxxxxx>
In-reply-to: <4BD8E9F8.4090701@xxxxxxxxxxx>
References: <4BD8E9F8.4090701@xxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Apr 28, 2010 at 09:07:52PM -0500, Eric Sandeen wrote:
> xfs_admin -c invokes repair directly to change lazy_count,
> but it doesn't write both features2 fields, so this:
> 
> # mkfs.xfs -dfile,name=fsfile,size=10g -llazy-count=0
> # xfs_admin -c 1 fsfile
> # xfs_repair fsfile
> 
> yields errors.
> 
> Reported-by: Marcin Mirosław <marcin@xxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>