[Top] [All Lists]

Re: [PATCH 00/11] remove xfs_iomap

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 00/11] remove xfs_iomap
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 29 Apr 2010 10:21:07 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx>
References: <20100428122850.075189557@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Apr 28, 2010 at 08:28:50AM -0400, Christoph Hellwig wrote:
> This series gets rid of the xfs_iomap structure which we use to
> communicate between xfs_aops.c and xfs_iomap.c.  It's not a very
> useful structure - we basically need block offsets above and below
> it, but it's in terms of bytes.  Removing it and using the xfs_bmbt_irec
> structure instead thus simplifies the code and reduces the stack footprint
> of the writeback code.

I like the idea - anything we can remove from the writeback path is
useful in terms of stack footprint. I've had a quick look over the
patches and can't see any obvious issues, but I need to do a more
in-depth review of them over the next couple of days. In the mean
time, I'll add them to my QA stack...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>